[FFI] Add python signal handler for ctypes FFI #17181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
approved these changes
Jul 22, 2024
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Sep 24, 2024
This reverts commit 91e9c63.
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Sep 24, 2024
This reverts commit 91e9c63. We noticed that the function `ctypes.pythonapi.PyErr_CheckSignals` may unexpectedly run into error and terminate the running process. Therefore, we revert this PR to avoid such termination.
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Sep 24, 2024
This reverts commit 91e9c63. We noticed that the function `ctypes.pythonapi.PyErr_CheckSignals` may unexpectedly run into error and terminate the running process. Therefore, we revert this PR to avoid such termination.
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Sep 27, 2024
This reverts commit 91e9c63. We noticed that the function `ctypes.pythonapi.PyErr_CheckSignals` may unexpectedly run into error and terminate the running process. Therefore, we revert this PR to avoid such termination.
MasterJH5574
added a commit
to MasterJH5574/tvm
that referenced
this pull request
Oct 2, 2024
This reverts commit 91e9c63. We noticed that the function `ctypes.pythonapi.PyErr_CheckSignals` may unexpectedly run into error and terminate the running process. Therefore, we revert this PR to avoid such termination.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signal handler is only registered for cython, it was missing for ctypes FFI.
cc @tqchen