Skip to content

[Relax][VM] Improved error messages for mismatched parameter count #17118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[Relax][VM] Improved error messages for mismatched parameter count #17118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/relax/backend/vm/exec_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ void ExecBuilderNode::EmitFunction(const std::string& func_name, int64_t num_inp
ICHECK_EQ(vmfunc.num_args, -2) << "Function " << func_name << " already defined";
vmfunc.num_args = num_inputs;
if (param_names.defined()) {
ICHECK_EQ(num_inputs, param_names.value().size())
<< "Function " << func_name << " defined with " << num_inputs << " arguments, "
<< "but the list of parameter names has " << param_names.value().size() << " names ("
<< param_names << ")";
std::vector<std::string> names;
for (auto name : param_names.value()) {
names.push_back(name);
Expand Down
20 changes: 17 additions & 3 deletions src/runtime/relax_vm/vm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,9 +678,23 @@ RegType VirtualMachineImpl::InvokeBytecode(Index gf_idx, const std::vector<RegTy
}

// load arguments to the register file
ICHECK_EQ(static_cast<size_t>(gfunc.num_args), args.size())
<< "ValueError: Invoking function " << gfunc.name << " requires " << gfunc.num_args
<< " inputs but only " << args.size() << " inputs are provided.";
ICHECK_EQ(static_cast<size_t>(gfunc.num_args), args.size()) << "ValueError: Invoking function "
<< gfunc.name << " expects "
<< gfunc.num_args << " arguments" <<
[&]() {
std::stringstream ss;
if (gfunc.param_names.size()) {
ss << " (";
for (size_t i = 0; i < gfunc.param_names.size(); i++) {
if (i) {
ss << ", ";
}
ss << gfunc.param_names[i];
}
ss << ")";
}
return ss.str();
}() << ", but " << args.size() << " arguments were provided.";
for (size_t i = 0; i < args.size(); ++i) {
WriteRegister(frames_.back().get(), i, args[i]);
}
Expand Down