[Relax] Support input_axis_separator to allow 2D to 1D conversion
#17115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce input_axis_separator in relax.transform_layout op to allow conversion of 2D buffers to 1D buffers. The conversion from 2D->1D is handled while lowering of transform_layout operator. Also introducing support for input_axis_separator in AlterOpImpl pass.
abhikran-quic
force-pushed
the
input_axis_sep
branch
2 times, most recently
from
a7018ad to
778557e
Compare
abhikran-quic
force-pushed
the
input_axis_sep
branch
from
778557e to
28a4bb6
Compare
abhikran-quic
changed the title
input_axis_separator to allow 2D to 1D conversion
Contributor
Author
|
cc: @Lunderberg , @tqchen |
Lunderberg
reviewed
Jun 26, 2024
abhikran-quic
commented
Jun 27, 2024
Contributor
Author
abhikran-quic
left a comment
abhikran-quic
left a comment
There was a problem hiding this comment.
Thank you @Lunderberg for your comments. I've addressed them in a new commit.
abhikran-quic
force-pushed
the
input_axis_sep
branch
from
03a6ad4 to
13ddd8c
Compare
abhikran-quic
force-pushed
the
input_axis_sep
branch
from
13ddd8c to
fb63b4a
Compare
Lunderberg
approved these changes
Jun 28, 2024
Contributor
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
Thank you for making the changes, and it looks good!
Contributor
Author
|
@tvm-bot rerun |
Contributor
|
Thanks @abhikran-quic @Lunderberg |
Contributor
Author
|
Thank you @Lunderberg, @quic-sanirudh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input_axis_separatorinrelax.transform_layoutop for 2D input buffer to allow conversion of 2D buffers to 1D buffers. The conversion from 2D->1D is handled while lowering oftransform_layoutoperator.axis_separator, theinput_axis_separatorhelps in identifying the buffers with 2 dimensions especially when the conversion is needed to 1D operation.input_axis_separatorinAlterOpImplpass.