[Frontend][ArgParse] Pass default values to target compiler(#13264) #17014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]>
MNGanesan
commented
May 21, 2024
added 3 commits
June 10, 2024 17:27
) BYOC Compiler's Config node defines the target compiler's command line options, along with default values. This change extract the default values from config node, while constructing target options for codegen/target compiler. Added test case for this feature as well. Signed-off-by: M N Ganesan <[email protected]>
…anesan/tvm into pass_default_values_for_args
Signed-off-by: M N Ganesan <[email protected]>
Contributor
Author
|
Could you please review this change ? |
Contributor
Author
Contributor
|
Sorry @MNGanesan - I'm not a maintainer of TVM. |
Hzfengsy
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In BYOC, Marvell Compiler Config node defines the target compiler's command line options, along with default values. When the user has not given any explicit command line options, these default values can be extracted from the configuration and passed to the TVM's Argument Parser. Currently the support for extraction of default values from Config options is not there, this change introduces that support. Also this is done conditionally by interpreting the flag status of target compiler.