[Disco] Expose disco.Session.shutdown through the python API #16979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `SessionObj::Shutdown` method could be called from the C++ API, but could not be called through the Python API. While it is implicitly called when the `SessionObj` is destructed, Python's garbage collection may result in the destruction occurring later than expected. This commit exposes `SessionObj::Shutdown` through the Python API as `disco.Session.shutdown`, allowing it to be closed cleanly.
masahi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
SessionObj::Shutdownmethod could be called from the C++ API, but could not be called through the Python API. While it is implicitly called when theSessionObjis destructed, Python's garbage collection may result in the destruction occurring later than expected.This commit exposes
SessionObj::Shutdownthrough the Python API asdisco.Session.shutdown, allowing it to be closed cleanly.