[Fix] Fix numpy dtype map #16780
Merged
[Fix] Fix numpy dtype map #16780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy 2.0 removes the dtype `np.float_`, which may introduces compatibility issue for TVM.
Contributor
|
I think this is better. - if np.__version__.startswith("1."):
- NUMPY2STR[np.dtype(np.float_)] = "float64"
+ if hasattr(np, "float_"):
+ NUMPY2STR[np.dtype(np.float_)] = "float64" |
Contributor
|
This is more Pythonic? - if np.__version__.startswith("1."):
- NUMPY2STR[np.dtype(np.float_)] = "float64"
+ try:
+ NUMPY2STR[np.dtype(np.float_)] = "float64"
+ except AttributeError:
+ pass |
tqchen
approved these changes
Mar 25, 2024
Contributor
Author
|
@mshr-h Thank you for the great suggestion! I agree that the way I was doing might not be the best. Feel free to send the change you propose. |
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
NumPy 2.0 removes the dtype `np.float_`, which may introduces compatibility issue for TVM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy 2.0 removes the dtype
np.float_, which may introduces compatibility issue for TVM.