[LLVM] Lack of DWARF type is not an error #16748
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `CodeGenLLVM::GetDebugType` would raise an exception if it could not convert the TIR data type to an equivalent DWARF type for debug symbols. This commit updates the behavior to instead return `nullptr`, representing an unknown type in DWARF
vinx13
approved these changes
Mar 22, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
Prior to this commit, the `CodeGenLLVM::GetDebugType` would raise an exception if it could not convert the TIR data type to an equivalent DWARF type for debug symbols. This commit updates the behavior to instead return `nullptr`, representing an unknown type in DWARF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the
CodeGenLLVM::GetDebugTypewould raise an exception if it could not convert the TIR data type to an equivalent DWARF type for debug symbols. This commit updates the behavior to instead returnnullptr, representing an unknown type in DWARF