[Relax][Frontend][NN] Add support for Conv3D #16654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yongwww
reviewed
Feb 28, 2024
Member
yongwww
left a comment
yongwww
left a comment
There was a problem hiding this comment.
thanks for adding the support, it looks good
yongwww
approved these changes
Feb 29, 2024
jwfromm
force-pushed
the
jwfromm/nn_conv3d
branch
from
0e6713d to
c73a640
Compare
Member
|
@tvm-bot rerun |
1 similar comment
Member
|
@tvm-bot rerun |
jwfromm
force-pushed
the
jwfromm/nn_conv3d
branch
from
c73a640 to
fb4f432
Compare
Member
|
@tvm-bot rerun |
jwfromm
force-pushed
the
jwfromm/nn_conv3d
branch
from
fb4f432 to
1c80d0c
Compare
Lunderberg
pushed a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
thaisacs
pushed a commit
to thaisacs/tvm
that referenced
this pull request
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands Relax's NN frontend with operators needed to support emerging video models like SVD. The main change needed is adding support for Conv3D, but a few other minor changes were found to be helpful as well. Specifically the ability to rewrite resize2D's layout manually was quite helpful for performance, so I expanded it's convertlayout pass to support that. I also added a few more options to Conv2D in the nn frontend such as specifying layout.