[TVMScript] Represent tir::builtin::ret() using python "return" #16640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TIR equivalent of python's `return` statement is the `tir::builtin::ret()` operator. Prior to this commit, this was printed as `T.ret(value)`, and any use of `return` statement in TVMScript produced an error while parsing. This commit updates the TVMScript parsing to produce `T.ret(value)` for the python `return value` statement. If syntax sugar is enabled, the TIR `T.ret(value)` will be printed as `return value`.
slyubomirsky
approved these changes
Feb 27, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
A nice parsing improvement 🙂
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
Mar 12, 2024
…he#16640) The TIR equivalent of python's `return` statement is the `tir::builtin::ret()` operator. Prior to this commit, this was printed as `T.ret(value)`, and any use of `return` statement in TVMScript produced an error while parsing. This commit updates the TVMScript parsing to produce `T.ret(value)` for the python `return value` statement. If syntax sugar is enabled, the TIR `T.ret(value)` will be printed as `return value`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TIR equivalent of python's
returnstatement is thetir::builtin::ret()operator. Prior to this commit, this was printed asT.ret(value), and any use ofreturnstatement in TVMScript produced an error while parsing.This commit updates the TVMScript parsing to produce
T.ret(value)for the pythonreturn valuestatement. If syntax sugar is enabled, the TIRT.ret(value)will be printed asreturn value.