[Relax] Expose name_hint field for BlockBuilder.match_cast #16600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, while a `relax.VarBinding` created using `BlockBuilder.emit` could have its name explicitly specified by the user, a `relax.MatchCast` created using `BlockBuilder.match_cast` could not. This commit updates `BlockBuilder.match_cast` to accept an optional `name_hint` parameter, which is then provided to the C++ `BlockBuilder::EmitMatchCast` method.
Hzfengsy
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, while a
relax.VarBindingcreated usingBlockBuilder.emitcould have its name explicitly specified by the user, arelax.MatchCastcreated usingBlockBuilder.match_castcould not. This commit updatesBlockBuilder.match_castto accept an optionalname_hintparameter, which is then provided to the C++BlockBuilder::EmitMatchCastmethod.