[RUNTIME][OPENCL] delay device check #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
tqchen
approved these changes
Aug 25, 2018
ZhennanQin
pushed a commit
to ZhennanQin/tvm
that referenced
this pull request
Sep 6, 2018
FrozenGene
pushed a commit
to FrozenGene/tvm
that referenced
this pull request
Dec 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the problem reported in https://discuss.tvm.ai/t/compiler-bug-cant-cross-compile-opencl-target-without-opencl-device/694
Currently, the OpenCL runtime fails to build a module when there is no OpenCL device. This PR delays the check of the device existence to allow cross-compiling.
I also updated the document of SDAccel because, with this change, we can create a bitstream on non-FPGA environment without emulated devices.