-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[CI] Disable testing that downloads from mxnet #16546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The mxnet project was archived in 2023-09 ([link](https://attic.apache.org/projects/mxnet.html)). Downloads from the mxnet AWS links (e.g. `https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/models/resnet18_v1-a0666292.zip`) no longer can be performed. This commit disables TVM CI steps that depend on downloading models from these locations.
|
mxnet is getting deprecated, so we should remove the testcases/example that depends on it |
|
opened a related tracking issue #16547 |
|
That was my guess, and agreed that it doesn't make sense to maintain integration with a deprecated framework. Marking this PR as ready for review, so that it can unblock CI. It still attempts to download files, but should bail out on error rather than failing CI altogether. A follow-up PR can then remove the test cases altogether. |
yongwww
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to have it to unblock the CI.
|
Looks like CI is passing, except for the ARM tests, which are stalled waiting for |
|
arm tests are stuck #16549 |
|
Thank you for mentioning that. Looks like the ARM CI was related to another of my PRs, which I recently rebased onto main. I've unstuck the ARM tests, and CI has now passed here. |
The mxnet project was archived in 2023-09 (link). Downloads from the mxnet AWS
links (e.g.
https://apache-mxnet.s3-accelerate.dualstack.amazonaws.com/gluon/models/resnet18_v1-a0666292.zip) no longer can be performed. This commit disables TVM CI steps that depend on downloading models from these locations.