[Build] Improving debug and build-dir options #16524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2024 10:33
Adding debug option to task_build to allow debug version of TVM to be built easily. Adding --build-dir option to bash.sh to allow which directory holds the built tvm to be patches through to docker.
neildhickey
force-pushed
the
build_system_improvements
branch
from
d8d261b to
638714b
Compare
lhutton1
approved these changes
Feb 8, 2024
Contributor
lhutton1
left a comment
lhutton1
left a comment
There was a problem hiding this comment.
Thanks @neildhickey, LGTM!
Contributor
|
cc @Liam-Sturge |
lhutton1
approved these changes
Feb 12, 2024
Contributor
|
Thanks @neildhickey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding debug option to task_build to allow debug version of TVM to be built easily.
Adding --build-dir option to bash.sh to specify which directory holds the built tvm to be patched through to docker.