[Unity][Transform] Raise error in FuseOpsByPattern for SSA violation #16421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lunderberg
force-pushed
the
unity_check_ssa_in_fuse_ops
branch
from
205e97d to
65dc49a
Compare
Internally, `FuseOpsByPattern` makes a mapping from relax variables to the fused group containing that variable. If the input module violates SSA, this map may be ill-formed. While not strictly necessary for FuseOps to handle ill-formed inputs, checking it at this level provides better error handling than propagating it to downstream passes. This commit checks for ill-formed inputs that would produce invalid fused outputs and raises an error.
Lunderberg
force-pushed
the
unity_check_ssa_in_fuse_ops
branch
from
65dc49a to
47adfd6
Compare
Contributor
Author
|
Rebased onto main to resolve conflicts |
slyubomirsky
approved these changes
Feb 22, 2024
Contributor
slyubomirsky
left a comment
slyubomirsky
left a comment
There was a problem hiding this comment.
It's always good to have better error-checking, especially when the messages can be more meaningful. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally,
FuseOpsByPatternmakes a mapping from relax variables to the fused group containing that variable. If the input module violates SSA, this map may be ill-formed. While not strictly necessary for FuseOps to handle ill-formed inputs, checking it at this level provides better error handling than propagating it to downstream passes.This commit checks for ill-formed inputs that would produce invalid fused outputs and raises an error.