Skip to content

[Vulkan] Some fixes of Vulkan codegen #16405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Vulkan] Some fixes of Vulkan codegen #16405

wants to merge 1 commit into from

Conversation

@spectrometerHBH
Copy link
Contributor

@spectrometerHBH spectrometerHBH commented Jan 16, 2024

  • add exp2 dispatch
  • handle thread invariant op
  • disable smem merge for vulkan

@spectrometerHBH spectrometerHBH mentioned this pull request Jan 16, 2024
Closed
@spectrometerHBH @junrushao
[Vulkan] Some fixes of Vulkan codegen
e2ed427 
- add exp2 dispatch
- handle thread invariant op
- disable smem merge for vulkan
@junrushao
Copy link
Member

junrushao commented Jan 17, 2024

Cherry-picked to mlc-ai/relax#309

junrushao pushed a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@LeshengJin @junrushao
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
6c7c7a5 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
7471cd1 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@junrushao junrushao mentioned this pull request Jan 17, 2024
Merged
junrushao added a commit to junrushao/tvm that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9cb8e28 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache#16404,
  apache#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
9c8cf08 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan
a7818f0 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
tqchen pushed a commit that referenced this pull request Jan 17, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
cbe9c14 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (mlc-ai/relax#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (mlc-ai/relax#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (mlc-ai/relax#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (#16404,
  #16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@tqchen
Copy link
Member

tqchen commented Jan 17, 2024

@tvm-bot rerun

junrushao added a commit to mlc-ai/relax that referenced this pull request Jan 21, 2024
@junrushao @spectrometerHBH @LeshengJin
[Bugfix][Unity] Recover MSVC/NVCC/ROCm/Vulkan (#16414)
62dfa27 
This PR upstreams a few commits that recovers the unity branch from
broken wheel packages. It includes the following changes:

- Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return
  type (#306);
- Fix MSVC build warnings on not recognizing "#pragma GCC"
  (#307);
- Fix NVCC build warnings where it fails to infer if "[[noreturn]]"
  actually does not return (#308);
- Fix ROCM/Vulkan backend which fails compilation for operators like group
  GEMM, paged attention, etc. (apache/tvm#16404,
  apache/tvm#16405)

Co-authored-by: Bohan Hou <[email protected]>
Co-authored-by: Lesheng Jin <[email protected]>
@Hzfengsy
Copy link
Member

Hzfengsy commented Jan 23, 2024

Please rebase :)

@junrushao
Copy link
Member

junrushao commented Jan 23, 2024

I think it's part of #16414 that has been merged

@tqchen tqchen closed this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spectrometerHBH @junrushao @tqchen @Hzfengsy