[TOPI][Target] Add fp16 SIMD support for conv2d on arm_cpu targets
#16383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Optimised fp16 conv2d matrix tiling for Arm(R) Neon(TM) instructions and exposed `+fullfp16` as a target feature for Arm(R) Cortex(R) A-Profile CPUs. Also, a target test was added to `cpptest` for Arm(R) Cortex(R) A-Profile CPUs which checks that the `has_fp16_simd` flag is set exclusively when the user explicitly passes the `+fullfp16` or `+sve` attributes and a supporting architecture version at target creation.
jwfromm
approved these changes
Jan 11, 2024
Contributor
jwfromm
left a comment
jwfromm
left a comment
There was a problem hiding this comment.
LGTM, thanks for the change!
ekalda
approved these changes
Jan 11, 2024
Contributor
ekalda
left a comment
ekalda
left a comment
There was a problem hiding this comment.
Looks good, thanks @Anndrey24!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimised fp16 conv2d matrix tiling for Arm(R) Neon(TM) instructions and exposed
+fullfp16as a target feature for Arm(R) Cortex(R) A-Profile CPUs.Also, a target test was added to
cpptestfor Arm(R) Cortex(R) A-Profile CPUs which checks that thehas_fp16_simdflag is set exclusively when the user explicitly passes the+fullfp16or+sveattributes and a supporting architecture version at target creation.cc @ekalda @lhutton1 @neildhickey