[Unity] Validate struct info in relax::Call constructor #16311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All operations called by a `relax::Call` node must have a `FuncStructInfo`. Prior to this commit, an invalid struct info would be caught by the `BlockBuilder` during normalization. This delay between the invalid `relax::Call` being constructed and the invalid `relax::Call` being detected makes debugging difficult. This commit adds an additional check during the `relax::Call` constructor, to provide earlier error detection.
…or_pr_16311 Pull in bugfix from apache#16322
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All operations called by a
relax::Callnode must have aFuncStructInfo. Prior to this commit, an invalid struct info would be caught by theBlockBuilderduring normalization. This delay between the invalidrelax::Callbeing constructed and the invalidrelax::Callbeing detected makes debugging difficult. This commit adds an additional check during therelax::Callconstructor, to provide earlier error detection.