[Unity] Dispatch cumsum and sort #16254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tqchen
requested changes
Dec 16, 2023
tqchen
reviewed
Dec 16, 2023
yongwww
force-pushed
the
dispatch_scan_sort
branch
from
4c535b2 to
e50dafe
Compare
yongwww
commented
Dec 17, 2023
junrushao
force-pushed
the
unity
branch
2 times, most recently
from
c95d45f to
45eeb8c
Compare
jinhongyii
requested changes
Dec 20, 2023
yongwww
force-pushed
the
dispatch_scan_sort
branch
from
0ee774e to
1e8cad2
Compare
yongwww
force-pushed
the
dispatch_scan_sort
branch
from
b4e0ff7 to
4896b66
Compare
jinhongyii
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to dispatch cumsum and sort to their platform dependent implementation in Relax. If no target is found, will default to go with GPU implementation. The dispatch pass was implemented in python, we might update the pattern a little bit when we introduce some specialized implementation, for example @vinx13's top2.
cc: @tqchen @vinx13 @jinhongyii