[Target] Support obtain l2 cache size from target #16039
Merged
+24
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
reviewed
Nov 2, 2023
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
Thanks a lot for sending this PR! Adding new target attribute makes sense to me as it could be beneficial to all users of this target tag. IMHO we don't need to introduce new function to support add_config as it's pretty much the same as set_config. Other than this LGTM.
CC: @junrushao
zxybazh
reviewed
Nov 6, 2023
Contributor
Author
|
@zxybazh Thanks for the review |
Ubospica
added a commit
to Ubospica/tvm-develop
that referenced
this pull request
Nov 13, 2023
* finished * 1106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports obtain l2 cache size from target. The API is
The l2 cache size is hardcoded in src/target/tag.cc.
This is useful for specializing schedule rules for different targets.
This PR is followup of #15332
cc @yzh119 @zxybazh