DLPack Conversion API #1573
DLPack Conversion API #1573
Conversation
| Parameters | ||
| ---------- | ||
| dltensor : DLPack tensor | ||
|
|
python/tvm/contrib/dlpack.py
Outdated
|
|
||
| Parameters | ||
| ---------- | ||
| tvm_func: Built tvm function operating on arrays |
There was a problem hiding this comment.
numpy docstring convention
tvm_func: Function
The original tvm function input
include/tvm/runtime/c_runtime_api.h
Outdated
| TVM_DLL int TVMArrayToDLPack(TVMArrayHandle from, | ||
| DLManagedTensor** out); | ||
|
|
||
| /**/ |
| Wrapped tvm function that operates on PyTorch tensors | ||
| """ | ||
| import torch | ||
| import torch.utils.dlpack |
There was a problem hiding this comment.
add a check to see if tvm_func is callable and raise error if it is not
python/tvm/contrib/dlpack.py
Outdated
| return tvm_func(*args) | ||
| return _wrapper | ||
|
|
||
| def to_pytorch(tvm_func): |
There was a problem hiding this comment.
to_pytorch_func to avoid confusion
tqchen
added
status: accepted
and removed
status: need update
|
Thanks @eqy ! this is merged |
|
Hi! I think you could check whether the sentence under |
|
@wkcn Thanks for pointing this out, that line should be changed to |
|
cc @eqy |
|
#1589 should fix the problem |
|
Yes. #1589 has fixed the problem :-) |
(do not merge yet)
cc @tqchen