Skip to content

Conversation

@Lunderberg
Copy link
Contributor

If the generated device function uses a buffer, generate a DeclBuffer for the buffer at the top of the device function.

This is a subset of the changes made in #14778, broken out for ease of testing and review.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 6, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

If the generated device function uses a buffer, generate a DeclBuffer
for the buffer at the top of the device function.

This is a subset of the changes made in
apache#14778, broken out for ease of
testing and review.
@Lunderberg Lunderberg force-pushed the declbuffer_output_from_split_host_device branch from 93fe0ba to 2538ac8 Compare August 15, 2023 16:18
Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks great to me!

@junrushao junrushao merged commit c921781 into apache:main Aug 28, 2023
@Lunderberg Lunderberg deleted the declbuffer_output_from_split_host_device branch August 29, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants