-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[FRONTEND][TFLITE][BugFix] Fix variable typo in batchmatmul converting func #15259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
|
Please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting that we don't see any test failing because of that. Any chance you could add a small test case to make sure it doesn't regress in future?
Thanks for the PR @rebel-shshin
Yeap I will do that :) |
leandron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy for this to be merged once CI is green.
Thanks @rebel-shshin!
|
Hi @leandron, any idea why |
neildhickey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@tvm-bot rerun |
It's probably a transient - I triggered a new set of CI for this patch now. |
Thanks |
|
This is merged now, thanks all. |
…g func (apache#15259) * TFLite frontend bug fix * Update tflite.py * lint * Add pytest
…g func (apache#15259) * TFLite frontend bug fix * Update tflite.py * lint * Add pytest
…g func (apache#15259) * TFLite frontend bug fix * Update tflite.py * lint * Add pytest
Fix a couple of variable names for tflite frontend.