Skip to content

Conversation

@rebel-shshin
Copy link
Contributor

Fix a couple of variable names for tflite frontend.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 7, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@rebel-shshin
Copy link
Contributor Author

rebel-shshin commented Jul 7, 2023

Please take a look.
cc @leandron @masahi @xiaosibai @neildhickey @tqchen
cheers~

Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that we don't see any test failing because of that. Any chance you could add a small test case to make sure it doesn't regress in future?

Thanks for the PR @rebel-shshin

@rebel-shshin
Copy link
Contributor Author

Interesting that we don't see any test failing because of that. Any chance you could add a small test case to make sure it doesn't regress in future?

Thanks for the PR @rebel-shshin

Yeap I will do that :)

@rebel-shshin
Copy link
Contributor Author

rebel-shshin commented Jul 10, 2023

cc @leandron
Hi @leandron, I added two test cases as you requested. Please take a look.

@rebel-shshin rebel-shshin requested a review from leandron July 10, 2023 12:51
Copy link
Contributor

@leandron leandron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy for this to be merged once CI is green.
Thanks @rebel-shshin!

@rebel-shshin
Copy link
Contributor Author

rebel-shshin commented Jul 11, 2023

Hi @leandron, any idea why gpu/pr-head fails?
I think my patch should not be affected the gpu test.

Copy link
Contributor

@neildhickey neildhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leandron
Copy link
Contributor

@tvm-bot rerun

@leandron
Copy link
Contributor

leandron commented Jul 11, 2023

Hi @leandron, any idea why gpu/pr-head fails?
I think my patch should not be affected the gpu test.

It's probably a transient - I triggered a new set of CI for this patch now.

@rebel-shshin
Copy link
Contributor Author

Hi @leandron, any idea why gpu/pr-head fails?
I think my patch should not be affected the gpu test.

It's probably a transient - I triggered a new set of CI for this patch now.

Thanks

@leandron leandron merged commit 33232de into apache:main Jul 11, 2023
@leandron
Copy link
Contributor

This is merged now, thanks all.

junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 24, 2023
…g func (apache#15259)

* TFLite frontend bug fix

* Update tflite.py

* lint

* Add pytest
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 27, 2023
…g func (apache#15259)

* TFLite frontend bug fix

* Update tflite.py

* lint

* Add pytest
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 30, 2023
…g func (apache#15259)

* TFLite frontend bug fix

* Update tflite.py

* lint

* Add pytest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants