-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity][FIX] add init file to relax.backend.contrib
#15023
Conversation
This PR adds `__init__.py` to `relax.backend.contrib`, fixing the package issue reported at mlc-ai/mlc-llm#311
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
relax.backend.contrib
relax.backend.contrib
The file was removed recently to fix a circular dep problem #15001 |
@masahi Thanks for sharing. However, |
# under the License. | ||
"""Relax backends contrib""" | ||
from . import cublas | ||
from . import cutlass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does keeping an empty init file fix the issue? We don't want from . import cutlass
(probably cublas as well) here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe it is fine to import cutlass as long as we are not importing partition_for_cutlass
like previously.
If
from tvm.contrib.cutlass import (
has_cutlass,
num_cutlass_partitions,
finalize_modules
)
doesn't get an error, I'm cool with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The empty init file is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the summary of the previous issue for reference:
- It is fine (for now) for
backend/contrib/cutlass.py
to depend oncontrib/cutlass/build.py
- But
contrib/cutlass/build.py
doesimport relax
, which transitively importsbackend/contrib/cutlass.py
This PR adds
__init__.py
torelax.backend.contrib
, fixing the package issue reported at mlc-ai/mlc-llm#311cc @yzh119 @tqchen