[microTVM] additional refactoring for enabling USE_MICRO in more builds #13909
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
alanmacd
changed the title
alanmacd
changed the title
| int TVMDeviceFreeDataSpace(DLDevice dev, void* ptr) { return TVMPlatformMemoryFree(ptr, dev); } | ||
|
|
||
| static bool IsContiguous(const DLTensor* arr) { | ||
| TVM_ATTRIBUTE_UNUSED static bool IsContiguous(const DLTensor* arr) { |
There was a problem hiding this comment.
Can you clarify why this was needed? was it for eliminating the warning?
There was a problem hiding this comment.
IsContiguous() is only used in an assert() below, so in a non-debug build we get an unused function warning
mehrdadh
left a comment
mehrdadh
left a comment
There was a problem hiding this comment.
LGTM, just waiting for others to take a look as well
| src/runtime/crt/microtvm_rpc_common/session.cc | ||
| src/runtime/crt/microtvm_rpc_common/write_stream.cc) | ||
| list(APPEND RUNTIME_SRCS ${TVM_CRT_SOURCES}) | ||
| include_directories(SYSTEM src/runtime/micro) |
There was a problem hiding this comment.
it needs a header in that directory to build those files that are in TVM_CRT_SOURCES, it's the same pattern used in other .cmake and CmakeLists.txt
4 participants
Additional changes that make it possible to enable USE_MICRO across nearly all builds except for hexagon or when USE_RPC is disabled. This mainly standardizes how the microTVM RPC common files are built across all platforms. There will be a follow-up PR that will enable USE_MICRO for nearly all build types once the best mechanism and behaviors for doing so is determined.