Skip to content

Conversation

@mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jan 7, 2023

This PR updates nrfjprog to latest (10.18.1) to fix issues related to running microTVM tests inside docker. The main issue was that with older version commands like nrfjprog --com was not working even with docker --privileged.

As a result of this update, we need to update ubuntu version from 18.04 to 20.04.

cc @driazati @gromero

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 7, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested review from driazati and gromero January 7, 2023 01:25

set -euxo pipefail

wget https://apt.llvm.org/llvm.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way we can validate this script before executing it? Or can we revert back to the previous way of adding the apt repos? Executing arbitrary scripts from the internet is generally a bad thing 😸

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From their website (https://apt.llvm.org/) I tried this:

deb http://apt.llvm.org/focal/ llvm-toolchain-focal main

But the issue was that this one is missing LLVM-13. We are not using llvm-13 in cortexm image but it was installing before.
cc @driazati

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this, thanks to @driazati pointers.

NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-12-1/nrfcommandlinetools10121linuxamd64.tar.gz
NRF_COMMANDLINE_TOOLS_INSTALLER=nRF-Command-Line-Tools_10_12_1_Linux-amd64.deb
JLINK_LINUX_INSTALLER=JLink_Linux_V688a_x86_64.deb
NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-18-1/nrf-command-line-tools-10.18.1_linux-amd64.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, there should be a hash we can check to ensure it's the file we expect?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this file from NRF website and they don't provide any hash based on my understanding
https://www.nordicsemi.com/Products/Development-tools/nrf-command-line-tools/download
I'm not sure if there's other way to find a hash for this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add SHA to verify the files

@mehrdadh mehrdadh requested a review from Mousius January 9, 2023 18:37
@mehrdadh mehrdadh force-pushed the ci/update_cortexm_ubuntu20 branch from 16ebf61 to 0dd4909 Compare January 9, 2023 18:50
@mehrdadh mehrdadh closed this Jan 9, 2023
@mehrdadh mehrdadh deleted the ci/update_cortexm_ubuntu20 branch January 9, 2023 19:00
@mehrdadh
Copy link
Member Author

mehrdadh commented Jan 9, 2023

@Mousius There was an issue with my branch name, which was not processing correctly to trigger the docker build. Here is the new PR
#13736

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants