-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[CI][Docker][Cortex-M]Update ci_cortexm to Ubuntu 20.04 and update nrfjprog version to 10.18.1 #13722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment. Generated by tvm-bot |
|
|
||
| set -euxo pipefail | ||
|
|
||
| wget https://apt.llvm.org/llvm.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we can validate this script before executing it? Or can we revert back to the previous way of adding the apt repos? Executing arbitrary scripts from the internet is generally a bad thing 😸
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From their website (https://apt.llvm.org/) I tried this:
deb http://apt.llvm.org/focal/ llvm-toolchain-focal main
But the issue was that this one is missing LLVM-13. We are not using llvm-13 in cortexm image but it was installing before.
cc @driazati
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed this, thanks to @driazati pointers.
| NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-12-1/nrfcommandlinetools10121linuxamd64.tar.gz | ||
| NRF_COMMANDLINE_TOOLS_INSTALLER=nRF-Command-Line-Tools_10_12_1_Linux-amd64.deb | ||
| JLINK_LINUX_INSTALLER=JLink_Linux_V688a_x86_64.deb | ||
| NRF_COMMANDLINE_TOOLS_URL=https://nsscprodmedia.blob.core.windows.net/prod/software-and-other-downloads/desktop-software/nrf-command-line-tools/sw/versions-10-x-x/10-18-1/nrf-command-line-tools-10.18.1_linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly here, there should be a hash we can check to ensure it's the file we expect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this file from NRF website and they don't provide any hash based on my understanding
https://www.nordicsemi.com/Products/Development-tools/nrf-command-line-tools/download
I'm not sure if there's other way to find a hash for this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add SHA to verify the files
16ebf61 to
0dd4909
Compare
This fixes the issue encountered in #13722. Tested in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-13738/1/pipeline
…e#13738) This fixes the issue encountered in apache#13722. Tested in https://ci.tlcpack.ai/blue/organizations/jenkins/tvm-docker/detail/PR-13738/1/pipeline
This PR updates nrfjprog to latest (10.18.1) to fix issues related to running microTVM tests inside docker. The main issue was that with older version commands like
nrfjprog --comwas not working even withdocker --privileged.As a result of this update, we need to update ubuntu version from 18.04 to 20.04.
cc @driazati @gromero