Remove temporary VTCM workspace APIs #13681
Merged
+2
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
janetsc
requested review from
Lunderberg and
csullivan
and removed request for
Lunderberg
Lunderberg
approved these changes
Jan 4, 2023
Contributor
Lunderberg
left a comment
Lunderberg
left a comment
There was a problem hiding this comment.
Changes look good to me, and thank you on the cleanup!
Contributor
|
LGTM as well. Thanks @janetsc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllocVtcmWorkspace and FreeVtcmWorkspace were temporary APIs for allocating VTCM. Now that AllocDataSpace supports VTCM, these can be removed as they are just wrappers.
cc: @adstraw