Skip to content

[TIR] Fix PlanAndUpdateBufferAllocationLocation not visiting constant buffer #13605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2022
Merged

[TIR] Fix PlanAndUpdateBufferAllocationLocation not visiting constant buffer #13605

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba96089
Fix PlanAndUpdateBufferAllocationLocation not visiting constant buffer
masahi Dec 13, 2022
bbd906c
add comment
masahi Dec 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions src/tir/transforms/plan_update_buffer_allocation_location.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,24 +61,35 @@ class BufferAllocateOrderCollector : public StmtExprVisitor {
}

private:
bool find(const Buffer& buf) {
return std::find(buffer_alloc_recorder_.begin(), buffer_alloc_recorder_.end(), buf) !=
buffer_alloc_recorder_.end();
}

void VisitStmt_(const BlockNode* op) final {
for (const Buffer& buffer : op->alloc_buffers) {
buffer_alloc_recorder_.push_back(buffer);
}
// Also visit match_buffers to collect constant buffers associated with AllocateConst nodes.
// These buffers only appear in read and match_buffer regions.
for (const auto& region : op->match_buffers) {
if (!find(region->source->buffer)) {
buffer_alloc_recorder_.push_back(region->source->buffer);
}
}

StmtExprVisitor::VisitStmt_(op);
}

void VisitExpr_(const BufferLoadNode* op) final {
if (std::find(buffer_alloc_recorder_.begin(), buffer_alloc_recorder_.end(), op->buffer) ==
buffer_alloc_recorder_.end()) {
if (!find(op->buffer)) {
buffer_alloc_recorder_.push_back(op->buffer);
}
StmtExprVisitor::VisitExpr_(op);
}

void VisitStmt_(const BufferStoreNode* op) final {
if (std::find(buffer_alloc_recorder_.begin(), buffer_alloc_recorder_.end(), op->buffer) ==
buffer_alloc_recorder_.end()) {
if (!find(op->buffer)) {
buffer_alloc_recorder_.push_back(op->buffer);
}
StmtExprVisitor::VisitStmt_(op);
Expand Down