[Logging] Mark LogFatal::~LogFatal as [[noreturn]] #13542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `LOG(FATAL) << "some error message";` throws an exception when the internal `LogFatal` object is constructed. However, the gcc warning "control reaches end of non-void function" resulted in a common pattern where a `LOG(FATAL)` statement was immediately followed by return of a default value, in order to suppress the warning. This commit marks the `LogFatal::~LogFatal` destructor with the C++11 attribute `[[noreturn]]`, indicating that calls into it will not resume the normal control flow. This suppresses the warning without requiring the extra `return` statement after `LOG(FATAL)`, as the compiler knows that control flow will not resume after `LOG(FATAL)`.
Collaborator
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Contributor
Author
|
After conversation with @kparzysz-quic , it looks like whether |
kparzysz-quic
approved these changes
Dec 2, 2022
Hzfengsy
approved these changes
Dec 4, 2022
Member
Hzfengsy
left a comment
Hzfengsy
left a comment
There was a problem hiding this comment.
LGTM. It can be beneficial to the dev experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
LOG(FATAL) << "some error message";throws an exception when the internalLogFatalobject is constructed. However, the gcc warning "control reaches end of non-void function" resulted in a common pattern where aLOG(FATAL)statement was immediately followed by return of a default value, in order to suppress the warning.This commit marks the
LogFatal::~LogFataldestructor with the C++11 attribute[[noreturn]], indicating that calls into it will not resume the normal control flow. This suppresses the warning without requiring the extrareturnstatement afterLOG(FATAL), as the compiler knows that control flow will not resume afterLOG(FATAL).