[MetaSchedule] Handle deserializing empty string RVs in trace #12481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxybazh
approved these changes
Aug 17, 2022
Member
zxybazh
left a comment
zxybazh
left a comment
There was a problem hiding this comment.
LGTM, only nit picking this evil quotation mark.
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…#12481) * trace.cc * add tests * remove assert * add proper test * lint * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems sometimes we can have random variables with names such as "" (this is not the empty string, but two quotation marks).
I believe this is suppose to hit "Case 2" in
TranslateInputRVsand become an empty string but this does not seem to be the case.Unsure if having an RV as "" may be problematic, if it is, this will certainly hide another bug
cc @junrushao1994