Skip to content

Conversation

@driazati
Copy link
Member

@driazati driazati commented Aug 5, 2022

This wraps all tests in pytest-forked (with n=1) so that segfaults and other
process-terminations are properly reported by pytest. With this reporting on issues like #12311 should be much better (segfaults become like any other test failure)

cc @Mousius @areusch @gigiblender

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2022

Built docs for commit fcf46ae can be found here.

@driazati driazati changed the title [ci] Test pytest-forked boxing [ci] Box all tests in pytest-forked Aug 5, 2022
@driazati driazati marked this pull request as ready for review August 5, 2022 18:20
@github-actions github-actions bot requested review from Mousius and areusch August 8, 2022 19:17
This wraps all tests in pytest-forked so that segfaults and other
process-terminations are properly reported by pytest
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh, i had thought this was blocked on needing to fix gpu loading but glad it passed CI, let's merge this.

@areusch areusch merged commit 1a3d36a into apache:main Aug 11, 2022
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
This wraps all tests in pytest-forked (with n=1) so that segfaults and other
process-terminations are properly reported by pytest. With this reporting on issues like apache#12311 should be much better (segfaults become like any other test failure)

Co-authored-by: driazati <[email protected]>
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
This wraps all tests in pytest-forked (with n=1) so that segfaults and other
process-terminations are properly reported by pytest. With this reporting on issues like apache#12311 should be much better (segfaults become like any other test failure)

Co-authored-by: driazati <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants