Use shape dtype on argreduce to determine return type. #12083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Member
|
LGTM, can you add the test from #11794? |
everton1984
force-pushed
the
argmax_return_type
branch
from
8ea8467 to
3ef4e70
Compare
Contributor
Author
|
@masahi Sure, I just added it under |
everton1984
force-pushed
the
argmax_return_type
branch
4 times, most recently
from
c0c5ecb to
274a1e6
Compare
Fix ArgReduce automatic return type inference by forcing it to use the datatype of the shape of the Tensor instead of the fixed Int32. Including additional tests.
everton1984
force-pushed
the
argmax_return_type
branch
from
274a1e6 to
a3a903b
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…e#12083) Fix ArgReduce automatic return type inference by forcing it to use the datatype of the shape of the Tensor instead of the fixed Int32. Including additional tests.
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…e#12083) Fix ArgReduce automatic return type inference by forcing it to use the datatype of the shape of the Tensor instead of the fixed Int32. Including additional tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the shape argument type instead of a fixed Int32 type, this expects the shape type to always be an integer. Fix #11794 .