[CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests #12011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `ci.py` script would execute all C++ unit tests in the `"build"` directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used by `task_cpp_unittest.sh`, either by the command line or by using the same `TVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument from `ci.py`. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults to the `"build"` directory. Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH` environment variable, and were not similarly affected.
Contributor
Author
|
Motivating reason was #11970, where a failure in the C++ tests in |
driazati
approved these changes
Jul 5, 2022
Member
driazati
left a comment
driazati
left a comment
There was a problem hiding this comment.
lgtm, thanks for cleaning this up!
Co-authored-by: driazati <[email protected]>
Otherwise, `set -u` rightly errors out for it being undefined.
blackkker
pushed a commit
to blackkker/tvm
that referenced
this pull request
Jul 7, 2022
…pache#12011) * [CI] Use command-line argument or TVM_BUILD_PATH for C++ unittests Previously, the `ci.py` script would execute all C++ unit tests in the `"build"` directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used by `task_cpp_unittest.sh`, either by the command line or by using the same `TVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument from `ci.py`. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults to the `"build"` directory. Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH` environment variable, and were not similarly affected. * Remove `name=name` in format script Co-authored-by: driazati <[email protected]> * Fix lint error * Use default expansion of TVM_BUILD_PATH Otherwise, `set -u` rightly errors out for it being undefined. Co-authored-by: driazati <[email protected]>
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jul 15, 2022
…pache#12011) * [CI] Use command-line argument or TVM_BUILD_PATH for C++ unittests Previously, the `ci.py` script would execute all C++ unit tests in the `"build"` directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used by `task_cpp_unittest.sh`, either by the command line or by using the same `TVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument from `ci.py`. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults to the `"build"` directory. Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH` environment variable, and were not similarly affected. * Remove `name=name` in format script Co-authored-by: driazati <[email protected]> * Fix lint error * Use default expansion of TVM_BUILD_PATH Otherwise, `set -u` rightly errors out for it being undefined. Co-authored-by: driazati <[email protected]>
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
…pache#12011) * [CI] Use command-line argument or TVM_BUILD_PATH for C++ unittests Previously, the `ci.py` script would execute all C++ unit tests in the `"build"` directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used by `task_cpp_unittest.sh`, either by the command line or by using the same `TVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument from `ci.py`. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if the `TVM_BUILD_PATH` is undefined, `task_cpp_unittest.sh` defaults to the `"build"` directory. Python unit tests executed through `ci.py` used the `TVM_LIBRARY_PATH` environment variable, and were not similarly affected. * Remove `name=name` in format script Co-authored-by: driazati <[email protected]> * Fix lint error * Use default expansion of TVM_BUILD_PATH Otherwise, `set -u` rightly errors out for it being undefined. Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
ci.pyscript would execute all C++ unit tests in the"build"directory, regardless of the docker image being used. This change allows a caller to specify the build directory to be used bytask_cpp_unittest.sh, either by the command line or by using the sameTVM_BUILD_PATH environment variable as used by the top-level Makefile, and passes this argument fromci.py. To preserve the existing behavior for the pre-commit CI, if no argument is passed and if theTVM_BUILD_PATHis undefined,task_cpp_unittest.shdefaults to the"build"` directory.Python unit tests executed through
ci.pyused theTVM_LIBRARY_PATHenvironment variable, and were not similarly affected.cc @Mousius @areusch @driazati