Skip to content

[CI Image] support CSI-NN2 in ci_qemu #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2022
Merged

[CI Image] support CSI-NN2 in ci_qemu #11689

merged 2 commits into from
Jun 21, 2022

Conversation

@alter-xp
Copy link
Contributor

@alter-xp alter-xp commented Jun 13, 2022 •
edited
Loading

Introduce CSI-NN2 Compute Library into TVM to accelerate the inference performance of RISC-V CPU with Vector Extension

  • build CSI-NN2, download related toolchain and qemu
    @areusch

@alter-xp alter-xp mentioned this pull request Jun 13, 2022
Closed
3 tasks
@alter-xp alter-xp force-pushed the docker_env_csinn2 branch from 1e7950b to 1a5af61 Compare June 13, 2022 09:18
@alter-xp
[CI Image] support CSI-NN2 in ci_qemu
a1c25e6 
* build CSI-NN2, download related toolchain and qemu
@alter-xp alter-xp force-pushed the docker_env_csinn2 branch from 1a5af61 to a1c25e6 Compare June 13, 2022 11:00
areusch
areusch reviewed Jun 14, 2022
View reviewed changes
Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @alter-xp, once the RFC lands we can open a tracking issue for the RFC as a whole, tag this issue there, then land this change.

docker/install/ubuntu_download_csinn2_compute_lib.sh Outdated
install_path="/opt/csi-nn2"

# Clone CSI-NN2 Compute Library source code
git clone https://github.com/T-head-Semi/csi-nn2.git ${install_path}
Copy link
Contributor

@areusch areusch Jun 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we periodically rebuild images e.g. if we are going to update our Python version. do you guys mind pinning this version so we don't accidentally pull in new changes and break your tests in the process of updating something else?

also, possible to do a shallow clone e.g. --depth=1 to keep the size of the CI images down?

Copy link
Contributor Author

@alter-xp alter-xp Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for advice, we are glad to do so.

@alter-xp
Copy link
Contributor Author

alter-xp commented Jun 15, 2022

thanks @alter-xp, once the RFC lands we can open a tracking issue for the RFC as a whole, tag this issue there, then land this change.

a tracking issue is ready. I will keep updating it when RPC land.

@areusch
Copy link
Contributor

areusch commented Jun 16, 2022

hey @alter-xp i think our CI didn't quite do the right thing--#11756 should fix. it'd be great to retrigger CI on your PR after that goes in (i think i can do this myself, i'll ping you if not).

@alter-xp
Copy link
Contributor Author

alter-xp commented Jun 17, 2022

okay, thanks @areusch.

@areusch areusch merged commit 6282658 into apache:main Jun 21, 2022
@areusch
Copy link
Contributor

areusch commented Jun 21, 2022

thanks @alter-xp ! can you open an "Update Docker Image" GH issue once the nightly rebuild has passed with this PR?

@alter-xp
Copy link
Contributor Author

alter-xp commented Jun 22, 2022

thanks @areusch. Actually, I already built an issue. I will keep updating it when the nightly rebuild has passed.

This was referenced Jun 29, 2022
Closed
Merged
blackkker pushed a commit to blackkker/tvm that referenced this pull request Jul 7, 2022
@alter-xp @blackkker
[CI Image] support CSI-NN2 in ci_qemu (apache#11689)
9f945e3 
* [CI Image] support CSI-NN2 in ci_qemu

* build CSI-NN2, download related toolchain and qemu

* using fixed csinn2 branch
@alter-xp alter-xp deleted the docker_env_csinn2 branch February 20, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areusch areusch areusch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alter-xp @areusch