[ci][docker] Use sccache everywhere by default #11267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `/opt/sccache` to the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache. This will require a follow up PR to update the Docker images and remove some of the sccache logic in `task_build.py`
Contributor
|
just confirming--we can disable this when doing a local build, correct? what's the mechanism by which we do that? |
Member
Author
|
You can disable it by setting the compiler in the cmake config as usual ( |
Contributor
|
right, will this make the default tests/scripts/ci.py take up a bunch of disk though by making a local sccache? |
Contributor
|
we discussed a bit, this is expected to populate |
areusch
approved these changes
May 11, 2022
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
May 16, 2022
This adds `/opt/sccache` to the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache. This will require a follow up PR to update the Docker images and remove some of the sccache logic in `task_build.py` Co-authored-by: driazati <[email protected]>
shtinsa
pushed a commit
to Deelvin/tvm
that referenced
this pull request
May 17, 2022
This adds `/opt/sccache` to the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache. This will require a follow up PR to update the Docker images and remove some of the sccache logic in `task_build.py` Co-authored-by: driazati <[email protected]>
shingjan
pushed a commit
to shingjan/tvm
that referenced
this pull request
May 17, 2022
This adds `/opt/sccache` to the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache. This will require a follow up PR to update the Docker images and remove some of the sccache logic in `task_build.py` Co-authored-by: driazati <[email protected]>
SebastianBoblest
pushed a commit
to SebastianBoblest/tvm
that referenced
this pull request
May 27, 2022
This adds `/opt/sccache` to the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache. This will require a follow up PR to update the Docker images and remove some of the sccache logic in `task_build.py` Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
/opt/sccacheto the PATH of each of the CI docker images so when cmake looks for a C compiler it will pick up the sccache wrapper by default. This fixes some issues where compiler invocations weren't being run though sccache. With this approach the invoker doesn't need to do anything specific to set up sccache.This will require a follow up PR to update the Docker images and remove some of the sccache logic in
task_build.pycc @Mousius @areusch