[Relay][AST] Add WithFields for Constant and GlobalVar #10929
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikepapadim
force-pushed
the
extend_withfields
branch
from
df7aaa6 to
d8cd3cc
Compare
Contributor
|
I think this PR needs some more detail on what it's adding and why (is this part of a larger issue/RFC?) It should also include some simple tests to demonstrate the functionality. |
Co-authored-by: Mark Shields <[email protected]>
mikepapadim
force-pushed
the
extend_withfields
branch
from
d8cd3cc to
1f82a54
Compare
Contributor
Author
|
PTAL this one now introduces cpp tests for the |
mbaret
reviewed
Apr 13, 2022
Comment on lines
+36
to
+37
| ICHECK(func_init->span == func_cp->span); | ||
| ICHECK(func_init->checked_type_ == func_cp->checked_type_); |
Contributor
There was a problem hiding this comment.
I think we need to explicitly set these fields so that we know they're being preserved by WithFields (same for next test).
areusch
added
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Mark Shields [email protected]
This PR adds
WithFieldsfor Constant and GlobalVar.It is an addition of the original work described in #9569 and #9533 which provided support for the reminder of the relay nodes.
@mbs-octoml @mbaret