[TIR] Check dynamic shared memory in VerifyGPUCode #10923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
feat/verify_gpu_dyn_shmem
branch
from
2a67118 to
f356247
Compare
junrushao
approved these changes
Apr 6, 2022
masahi
reviewed
Apr 7, 2022
| local_memory_per_block_ += size * op->dtype.bytes() * op->dtype.lanes(); | ||
| } else if (scope == "shared") { | ||
| } else if (storage_scope.rank == runtime::StorageRank::kShared) { | ||
| size_t size = static_cast<size_t>(op->ConstantAllocationSize()); |
Member
There was a problem hiding this comment.
Note that op->ConstantAllocationSize() is 0 for symbolic shape dyn-shared memory. But VerifyGPUCode cannot do anything with symbolic shape, so this should be fine.
masahi
approved these changes
Apr 7, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @junrushao1994 @masahi