[FQ2I] Add abs to FQ2I #10922
Merged
[FQ2I] Add abs to FQ2I #10922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
anwang2009
changed the title
AndrewZhaoLuo
approved these changes
Apr 8, 2022
mehrdadh
pushed a commit
to mehrdadh/tvm
that referenced
this pull request
Apr 11, 2022
* add abs to fq2i * lint * special case for fq2i * np iinfo
Lucien0
pushed a commit
to Lucien0/tvm
that referenced
this pull request
Apr 19, 2022
* add abs to fq2i * lint * special case for fq2i * np iinfo
altanh
pushed a commit
to altanh/tvm
that referenced
this pull request
Apr 28, 2022
* add abs to fq2i * lint * special case for fq2i * np iinfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
absto the FakeQuantizationToInteger pass.Note that the FQ2I int abs implementation should not overflow, but rather clip when the absolute value of the minimum representable int value is taken. The FQ2I registration reflects this. Otherwise, in the fq2i test I was seeing abs(-128) => -128