[Arith] Support dtype promotion in TIR comparison expr creation #10584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got an error below when working on a model. This change fixes it.
These operator overload are "dtype-promotion aware", see
tvm/src/tir/op/op.cc
Line 471 in 7e2467a
Unfortunately, I've hit this problem on a very large model (QAT BERT-large) and I don't know why it is happening at all. So I don't have a minimum repro test.
@junrushao1994 @vinx13 @spectrometerHBH @wrongtest