[Runtime][PipelineExecutor] Add the pipeline internal forwarding logic. #10543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch use the SPSC lock free queue to forward the runtime output data into the child runtime input interface.
huajsj
requested review from
ZihengJiang,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
kazum,
liangfu,
masahi,
merrymercy,
tmoreau89,
tqchen,
vinx13 and
yzhliu
as code owners
15 tasks
Contributor
Author
masahi
reviewed
Mar 11, 2022
masahi
reviewed
Mar 11, 2022
masahi
reviewed
Mar 13, 2022
| while (!forward_queue->Push<NDArray>(output)) { | ||
| if (PipelineIsStop()) { | ||
| LOG(INFO) << "The forwarding queue pushing is stopped due to the pipeline state " | ||
| << "is changed into stop."; |
Contributor
Author
There was a problem hiding this comment.
fixed.
"The forwarding process is stopped after the pipeline status is changed into stop."
masahi
approved these changes
Mar 14, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…c. (apache#10543) * [Runtime][PipelineExecutor] Add the pipeline internal forwarding logic. This patch use the SPSC lock free queue to forward the runtime output data into the child runtime input interface. * remove debug logic. * address review comments. * correct a variable comments. * address review comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[RFC] https://github.com/apache/tvm-rfcs/blob/main/rfcs/0014-pipeline-executor.md
[Issue] #8596
This patch use the SPSC lock free queue to forward the parent runtime output data into the child runtime input interface.
There are also some logic to handle data copy and "STOP" state check within some loops for example the loop of
push data .