Skip to content

[MetaSchedule] Bug Fix for Relay Integration #10534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 10, 2022
Merged

[MetaSchedule] Bug Fix for Relay Integration #10534

merged 6 commits into from
Mar 10, 2022

Conversation

@zxybazh
Copy link
Member

@zxybazh zxybazh commented Mar 8, 2022 •
edited
Loading

This PR introduces 2 bug fixes:

  1. The PrimFuncs are not lowered before sent to codegen after applying tuned ones from meta schedule.
  2. The order of input output tensors for given PrimFunc was same as before lowering.

Thanks @sunggg @junrushao1994 for helping me debug and figure out the cause.

@masahi
Copy link
Member

masahi commented Mar 9, 2022

@zxybazh Can you remove the debug log at

tvm/src/meta_schedule/integration.cc

Line 145 in 085d36c

LOG(INFO) << "\n" << tir::AsTVMScript(func);

and

tvm/src/meta_schedule/integration.cc

Line 139 in 085d36c

LOG(INFO) << "Applied history best for: " << task_name;

?

@zxybazh
Copy link
Member Author

zxybazh commented Mar 10, 2022

Debug info removed and regression tests added.

@masahi masahi merged commit 201a584 into apache:main Mar 10, 2022
This was referenced Mar 10, 2022
Closed
Closed
pfk-beta pushed a commit to pfk-beta/tvm that referenced this pull request Apr 11, 2022
@zxybazh
[MetaSchedule] Bug Fix for Relay Integration (apache#10534)
1d7dbf2 
* Bug fix.

* Fix tune relay script.

* Remove debug info.

* Retest CI.

* Add regression test.

* Remove comments.
@driazati driazati mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahi masahi masahi approved these changes

@jroesch jroesch Awaiting requested review from jroesch

@slyubomirsky slyubomirsky Awaiting requested review from slyubomirsky

@icemelon icemelon Awaiting requested review from icemelon

@MarisaKirisame MarisaKirisame Awaiting requested review from MarisaKirisame

@ZihengJiang ZihengJiang Awaiting requested review from ZihengJiang

@yzhliu yzhliu Awaiting requested review from yzhliu

@vinx13 vinx13 Awaiting requested review from vinx13

@mbrookhart mbrookhart Awaiting requested review from mbrookhart

@jwfromm jwfromm Awaiting requested review from jwfromm

@zhiics zhiics Awaiting requested review from zhiics

@anijain2305 anijain2305 Awaiting requested review from anijain2305

@wweic wweic Awaiting requested review from wweic

@junrushao junrushao Awaiting requested review from junrushao

@comaniac comaniac Awaiting requested review from comaniac

@tqchen tqchen Awaiting requested review from tqchen

@areusch areusch Awaiting requested review from areusch

@merrymercy merrymercy Awaiting requested review from merrymercy

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zxybazh @masahi