[FIX] Only allow autoscheduler layout rewritting in conv2d_nhwc #10522
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Autoscheduler cannot handle layout rewritting for grouped convolutions and non-nhwc layouts. Previously layout rewriting was enabled for all convolutions causing errors where autoscheduler generated too large layouts like `64N4n1n1n1H1W68C1n1h1w2c2n`. Autoscheduler is now only enabled on non-grouped conv2d_nhwc.
tkonolige
requested review from
Huyuwei,
Laurawly,
ZihengJiang,
jcf94,
jwfromm,
kevinthesun,
masahi,
mbrookhart,
vinx13 and
yzhliu
as code owners
AndrewZhaoLuo
approved these changes
Mar 7, 2022
Contributor
Author
|
@AndrewZhaoLuo I have no clue. |
Contributor
|
Can you open up an issue, add it to a TODO in code. Then I shall merge once CI passes B) |
ziqiangxu8457
pushed a commit
to ziqiangxu8457/tvm
that referenced
this pull request
Mar 9, 2022
…he#10522) Autoscheduler cannot handle layout rewritting for grouped convolutions and non-nhwc layouts. Previously layout rewriting was enabled for all convolutions causing errors where autoscheduler generated too large layouts like `64N4n1n1n1H1W68C1n1h1w2c2n`. Autoscheduler is now only enabled on non-grouped conv2d_nhwc.
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
…he#10522) Autoscheduler cannot handle layout rewritting for grouped convolutions and non-nhwc layouts. Previously layout rewriting was enabled for all convolutions causing errors where autoscheduler generated too large layouts like `64N4n1n1n1H1W68C1n1h1w2c2n`. Autoscheduler is now only enabled on non-grouped conv2d_nhwc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Autoscheduler cannot handle layout rewritting for grouped convolutions and non-nhwc layouts. Previously layout rewriting was enabled for all convolutions causing errors where autoscheduler generated too large layouts like
64N4n1n1n1H1W68C1n1h1w2c2n. Autoscheduler is now only enabled on non-grouped conv2d_nhwc.@merrymercy @AndrewZhaoLuo