Skip to content

Add Check about negative uint constant #10484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 8, 2022
Merged

Add Check about negative uint constant #10484

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d43d50f
fix InferType bug
haoyang9804 Mar 2, 2022
dcf68c7
fix InferType related bug
haoyang9804 Mar 3, 2022
accdfc3
check if uint variable is negative
haoyang9804 Mar 4, 2022
7e2843f
check if uint variable is negative
haoyang9804 Mar 4, 2022
0f429c2
check if uint variable is negative
haoyang9804 Mar 4, 2022
72379cd
check if uint variable is negative
haoyang9804 Mar 4, 2022
1a84498
check if uint variable is negative
haoyang9804 Mar 4, 2022
9711c10
check if uint variable is negative
haoyang9804 Mar 4, 2022
62aa32b
check if uint variable is negative
haoyang9804 Mar 4, 2022
dfb927b
check if uint variable is negative
haoyang9804 Mar 4, 2022
5251121
check if uint variable is negative
haoyang9804 Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/arith/const_fold.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,9 @@ inline PrimExpr TryConstFold<tir::Add>(PrimExpr a, PrimExpr b) {
template <>
inline PrimExpr TryConstFold<tir::Sub>(PrimExpr a, PrimExpr b) {
TVM_ARITH_CONST_PROPAGATION({
ICHECK(!(pa && pa->dtype.is_uint() && pa->value == 0U && b.dtype().is_uint()))
<< "Checked failed. Minuend 's value is 0U and it's dtype is uint "
<< "while Subtrahend's dtype is uint; which will cause a negative uint";
const DataType& rtype = a.dtype();
if (pa && pb) return IntImm(rtype, pa->value - pb->value);
if (pb && pb->value == 0) return a;
Expand Down