Add remaining targets to ci.py #10425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driazati
force-pushed
the
repro
branch
3 times, most recently
from
e0b59f5 to
a047076
Compare
driazati
force-pushed
the
repro
branch
3 times, most recently
from
db0cb57 to
01bde8f
Compare
driazati
requested review from
a team,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
yzhliu and
zhiics
as code owners
areusch
reviewed
Mar 7, 2022
areusch
reviewed
Mar 12, 2022
Contributor
areusch
left a comment
areusch
left a comment
There was a problem hiding this comment.
overall looks good, couple of questions
python/tvm/_ffi/libinfo.py
Outdated
| use_runtime = os.environ.get("TVM_USE_RUNTIME_LIB", False) | ||
| dll_path = get_dll_directories() | ||
|
|
||
| manual_dll_path = os.getenv("TVM_DLL_PATH") |
Contributor
There was a problem hiding this comment.
i think we should say LIB not DLL, since DLL is meaningful only on windows. also, how does this differ from TVM_LIBRARY_PATH?
This adds build/test commands for all of the CI environments except ARM (that one will come in a follow up). Most of the invocations are similar and the scripts come straight from the Jenkinsfile. This improves the current situation by making it much easier to get CI environments locally. This also wraps pytest invocations in CI so that failures are parsed and a repro command is reported at the end of the failing CI run step alongside other logs to increase the visibility into this tool. This isn't perfect yet so some work (such as ARM support and certain tests that require pytest flags like in `tests/scripts/task_python_microtvm.sh`) is left for a follow up.
areusch
approved these changes
Mar 15, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* Add remaining targets to ci.py This adds build/test commands for all of the CI environments except ARM (that one will come in a follow up). Most of the invocations are similar and the scripts come straight from the Jenkinsfile. This improves the current situation by making it much easier to get CI environments locally. This also wraps pytest invocations in CI so that failures are parsed and a repro command is reported at the end of the failing CI run step alongside other logs to increase the visibility into this tool. This isn't perfect yet so some work (such as ARM support and certain tests that require pytest flags like in `tests/scripts/task_python_microtvm.sh`) is left for a follow up. * remove reporting changes * Clean up common functionality * Address comments * Comments Co-authored-by: driazati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds build/test commands for all of the CI environments. Most of the invocations are similar and the scripts come straight from the Jenkinsfile. This improves the current situation by making it much easier to get CI environments locally. In the future we might want to run the Jenkinsfile straight from this script, but for now they're duplicated and we have to keep them in sync manually (not a huge deal).
This isn't completely done yet so some work (such as certain tests that require pytest flags like in
tests/scripts/task_python_microtvm.sh) is left for a follow up.cc @areusch