[CMSIS-NN] Convert scalar constants to tensor constants #10100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asparkhi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
manupak,
mbaret,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
trevor-m,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
Change-Id: I9ea9c28b1410b4a80a9235af2e84bc80b4dc3a66
asparkhi
force-pushed
the
scalar_to_tensor_constant
branch
from
b000893 to
5d05eed
Compare
Change-Id: Ib916e4b29be124ccdf4c88936f10499b6642f141
asparkhi
force-pushed
the
scalar_to_tensor_constant
branch
from
5d05eed to
de0b6fb
Compare
Mousius
requested changes
Jan 31, 2022
Member
Mousius
left a comment
Mousius
left a comment
There was a problem hiding this comment.
First pass over this @ashutosh-arm, thanks for fixing this 😸
…hon functions, expanded variable names Change-Id: Ieacbe7b523e7ca4db54f15b4b7da117f421ec36b
Contributor
Author
|
Thanks for the review @Mousius. I have updated the PR with review comments. |
Change-Id: I625d5db043c987c46ca3521c3ce94873694d4d87
Member
|
Thanks @ashutosh-arm! This is merged now 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Pass that converts scalar constants into tensor constants for CMSIS-NN binary ops
-Updated extract_constants pass to support constants at any position in the function signature
-Modified tests for extract_constants pass corresponding to the scalar support
-Added new binary op tests to include constants