Don't use std::move in WithFields #10009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electriclilies
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
slyubomirsky,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
tkonolige
approved these changes
Jan 20, 2022
Contributor
tkonolige
left a comment
tkonolige
left a comment
There was a problem hiding this comment.
Thanks @electriclilies. I think these std::moves had basically no impact on performance too. This makes the code simpler and we don't have to worry about accidentally using something that was moved.
AndrewZhaoLuo
approved these changes
Jan 21, 2022
Contributor
Author
|
Thanks @AndrewZhaoLuo! |
yuanfz98
pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
* Don't use std::move in WithFields * lint
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* Don't use std::move in WithFields * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::move usually does nothing to improve perf, and I noticed a few places where std::move was causing a potential use-after-free. I suspect that some of these might have been contributing to some of the flaky seg faults we've been seeing recently. We'll see what happens when it goes thru CI.