vta: Update VTA to use load_pad_2d in compute #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update compute instruction VTA_MEM_ID_ACC to load using the load_pad_2d method instead of the load_2d. This resolves failing unit testing test_padded_load().
|
@tqchen Do you mind taking a look at this? |
|
cc @tmoreau89 |
tmoreau89
approved these changes
Dec 4, 2020
|
Thank you @dsteger, the PR has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update compute instruction VTA_MEM_ID_ACC to load using
the load_pad_2d method instead of the load_2d. This resolves
failing unit testing "test_padded_load()".
I've only tested this commit with the ultra96 using unit test ""test_vta_insn.py".