-
Notifications
You must be signed in to change notification settings - Fork 79
[RFC] Integrate LIBXSMM with TVM. #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
comaniac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the RFC and overall LGTM. One suggestion I have is that it would be great if you could provide an upstream plan that briefly explains how would you send PRs. To facilitate the review process, it is encouraged to break down your implementation to a series of small PRs. Here is an example of a PR series:
- Add libxsmm to the TVM CI.
- Add libxsmm to TOPI.
- Add libxsmm to Relay op strategy.
- Add libxsmm to BYOC.
Upstream plan added, at the end of RFC. By the way, I'm not quite sure what "TVM CI" refers to? If it means unit tests, they will be included in their related PRs when I upstream my code. |
|
@comaniac Any update? |
comaniac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Just try to polish the plan for the last time and we should be good to go.
|
@comaniac Thank you, I've updated the plan, please let me know if there is still problems. |
|
Thanks @zhuwenxi this is now merged. |
|
@comaniac OK, I'll update the RFC information soon. |
|
@comaniac I'm starting to implement the first PR "Add libxsmm to TVM CI" recently. I wonder if there is any CI-related PR I can refer to? |
You could refer to the PR like apache/tvm#9881 or something similar. |
Thank you! |
pre-RFC: https://discuss.tvm.apache.org/t/rfc-top-byoc-intel-libxsmm-integration/11688