-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] TIR Language Specification #101
Open
slyubomirsky
wants to merge
13
commits into
apache:main
Choose a base branch
from
slyubomirsky:tir-spec
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+752
−0
Open
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3d83908
Set up TIR spec RFC
slyubomirsky 925ba3c
Formatting fixes in spec
slyubomirsky c94e68b
Numbering fix
slyubomirsky 7ad2f7b
Formatting fixes and tweaks in RFC text
slyubomirsky fad2e80
Formatting tweak
slyubomirsky 38d00eb
Misplaced parenthesis
slyubomirsky c775a37
Discuss comparison of Div, Mod, FloorDiv, and FloorMod (thanks to @Lu…
slyubomirsky 77cce9e
Expand comment on FloorMod vs Mod
slyubomirsky bf1526a
Formatting fix
slyubomirsky 63ea41e
Fix typo in RFC
slyubomirsky 75b1726
Formatting
slyubomirsky a49badf
Draft rules for inter-PrimFunc calls
slyubomirsky c42e16c
Discuss function returns
slyubomirsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at it, I'm not sure on the "all values allocated within the PrimFunc are freed" is true.
If there is an
Allocate
node, it gets lowered to a matched pair of to the PackedFuncs registered as"tir.TVMBackendAllocWorkspace"
and"tir.TVMBackendFreeWorkspace"
. If the body of theAllocate
node contains an explicit return throughT.ret
, or an implicit return through anAssert
node, then the free wouldn't occur.Though, that's probably best considered a bug, and not intended behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you don't think it's the intended behavior, I think we should call that a bug then. Happy to hear others' thoughts.
edit: Alternatively, this can be a case of builtins not following the rules of the rest of the language. I can add a clause pointing to the existence of such complexities.