Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THRIFT-5829 - Update TConstant.php to remove deprecated PHP code #3059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pierrestudios
Copy link

remove deprecated use of static callables

  • Did you create an Apache Jira ticket? (Request account here, not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

remove deprecated use of static callables
@pierrestudios pierrestudios marked this pull request as ready for review October 30, 2024 12:33
@Jens-G Jens-G added the php label Oct 30, 2024
@Jens-G
Copy link
Member

Jens-G commented Oct 31, 2024

  1. Test\Thrift\Integration\Lib\ClassLoader\ThriftClassLoaderTest::testRegisterDefinition with data set "loadType" (array('/home/runner/work/thrift/thri.../phpcm'), 'Classmap\ThriftTest\Xtruct')
    ParseError: syntax error, unexpected '::' (T_PAAMAYIM_NEKUDOTAYIM), expecting ')'

/home/runner/work/thrift/thrift/lib/php/lib/Type/TConstant.php:44
/home/runner/work/thrift/thrift/lib/php/test/Resources/packages/phpcm/Classmap/ThriftTest/Types.php:4205
/home/runner/work/thrift/thrift/lib/php/lib/ClassLoader/ThriftClassLoader.php:109
/home/runner/work/thrift/thrift/lib/php/test/Integration/Lib/ClassLoader/ThriftClassLoaderTest.php:62

@Jens-G Jens-G added broken and removed broken labels Nov 1, 2024
@Jens-G Jens-G requested review from Jens-G and removed request for Jens-G November 1, 2024 23:56
Copy link
Member

@Jens-G Jens-G left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something boken here and should be fixed

@sveneld
Copy link
Contributor

sveneld commented Nov 2, 2024

I will look on this week.

@pierrestudios
Copy link
Author

I fixed the update in TConstant.php to make compatible wih PHP 7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants