Fix python compiler generated all_structs with type_hints #3040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fishy
force-pushed
the
py-type-hints-all-structs
branch
from
be1ddb6
to
4b99f31
Compare
|
Thank You! One can skip type checking the import or get around this with implicit Any but its much nicer to have this declared :) |
fishy
force-pushed
the
py-type-hints-all-structs
branch
from
4b99f31
to
9c86ede
Compare
Currently with type_hints enabled, we do not explicitly declare the type
of generated all_structs. It's meant to be a list of different types,
but that will cause problems, as the generated code is usually like
this:
all_structs = []
...
all_structs.append(Type1)
...
all_structs.append(Type2)
...
The first append infers the type of all_struct to be list[Type1], so
mypyc would start complaining from the 2nd append as the type is
unexpected.
Explicitly declare all_struct to be list[typing.Any] instead, which
fixes the issue.
fishy
force-pushed
the
py-type-hints-all-structs
branch
from
9c86ede
to
282bf9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently with type_hints enabled, we do not explicitly declare the type of generated all_structs. It's meant to be a list of different types, but that will cause problems, as the generated code is usually like this:
The first append infers the type of all_struct to be list[Type1], so mypy would start complaining from the 2nd append as the type is unexpected.
Explicitly declare all_struct to be list[typing.Any] instead, which fixes the issue.